net: skip IPv6 regex when the string has no colon - #66165
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
anonrig
marked this pull request as ready for review
September 21, 2026 04:07
IPv6 addresses always contain ':'. Reject IPv4 addresses and hostnames before running the IPv6 regular expression. Official benchmark/net/net-is-ip-v6.js is about 27% faster. net-is-ip-v4.js is unchanged. Assisted-by: a closed-source coding agent Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Co-authored-by: Yagiz Nizipli <anonrig@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/net-hotpath-ead2
branch
from
September 21, 2026 04:32
b4aacd6 to
da12549
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66165 +/- ##
==========================================
+ Coverage 90.27% 90.29% +0.02%
==========================================
Files 790 790
Lines 271651 272049 +398
Branches 51842 51939 +97
==========================================
+ Hits 245228 245658 +430
+ Misses 16928 16889 -39
- Partials 9495 9502 +7
🚀 New features to boost your workflow:
|
pimterry
approved these changes
Sep 21, 2026
Contributor
|
Benchmark GHA (net): https://github.com/nodejs/node/actions/runs/35579915982 |
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
Sep 21, 2026
Contributor
Failed to resume CI
Full Auto Start CI output |
Collaborator
Collaborator
|
Landed in 0a36bce |
aduh95
pushed a commit
that referenced
this pull request
Sep 27, 2026
IPv6 addresses always contain ':'. Reject IPv4 addresses and hostnames before running the IPv6 regular expression. Official benchmark/net/net-is-ip-v6.js is about 27% faster. net-is-ip-v4.js is unchanged. Assisted-by: a closed-source coding agent Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Co-authored-by: Yagiz Nizipli <anonrig@users.noreply.github.com> PR-URL: #66165 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
HoonDongKang
pushed a commit
to HoonDongKang/node
that referenced
this pull request
Sep 28, 2026
IPv6 addresses always contain ':'. Reject IPv4 addresses and hostnames before running the IPv6 regular expression. Official benchmark/net/net-is-ip-v6.js is about 27% faster. net-is-ip-v4.js is unchanged. Assisted-by: a closed-source coding agent Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Co-authored-by: Yagiz Nizipli <anonrig@users.noreply.github.com> PR-URL: nodejs#66165 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
net.isIPv6()always ran the large IPv6 regular expression, including for IPv4 addresses and hostnames. An IPv6 address always contains:, so reject those strings first.Object /
toStringinputs still go throughRegExp.prototype.testso existing coercion (covered bytest-net-isip.js) is unchanged.This change was implemented with assistance from a closed-source coding agent. I verified the source, official
benchmark/netresults, andtest-net-isip.js/test-net-blocklist.js.Official benches
Three-run medians,
n=1e7:net/net-is-ip-v6.jsnet/net-is-ip-v4.jsTests
test-net-isip.js,test-net-blocklist.js.